[Wien] compilation error - reg

[Peter Blaha]

This is an if between 2 integers and for that   .eq.   is the proper 
choice.

Only for comparison of logical variables some "clever" informatic guys 
have invented  .eqv.  instead of the old f77 standard.

> Another possibility is that the .eq. in the if statement is 
> problematic.  It's a little surprising that it even compiles as usually 
> the .eq. works fine for ifort but does not work for gfortran.  For both 
> ifort and gfortran to work, we have been having to change .eq. to .eqv.:
> 
> https://www.mail-archive.com/wien@zeus.theochem.tuwien.ac.at/msg18770.html
> https://www.mail-archive.com/wien@zeus.theochem.tuwien.ac.at/msg11545.html
> https://www.mail-archive.com/wien@zeus.theochem.tuwien.ac.at/msg18762.html
> 
> The information at the following links might be of interest:
> 
> https://www.mail-archive.com/wien@zeus.theochem.tuwien.ac.at/msg18767.html
> https://gcc.gnu.org/onlinedocs/gcc-3.4.6/g77/Equivalence-Versus-Equality.html#Equivalence-Versus-Equality
> https://gcc.gnu.org/onlinedocs/gcc-10.1.0/gfortran/Bitwise-logical-operators.html#Bitwise-logical-operators
> 
> On 5/9/2020 3:34 AM, Tran, Fabien wrote:
>> If the suggestion of P. Blaha does not help, remove "doit= .true." and rewrite it manually. Maybe there is some hidden character which perturbs the line.
>>
>> ________________________________________
>> From: Wien<wien-bounces at zeus.theochem.tuwien.ac.at>  on behalf of Peter Blaha<pblaha at theochem.tuwien.ac.at>
>> Sent: Saturday, May 9, 2020 8:57 AM
>> To:wien at zeus.theochem.tuwien.ac.at
>> Subject: Re: [Wien] compilation error - reg
>>
>> Which version of gfortran are you using ?
>>
>> Maybe the newest gfortran is "buggy" or is using some newest fortran
>> standard which has eliminated the default types of fortran.
>>
>> My gfortran-8 compiles this without problem.
>>
>> The offending statement:
>>
>> ados.f:79:48:
>>
>>      79 |       if(kpp.eq.kselect.and.kselect.gt.0) doit= .true.
>>         |                                                1
>> Error: Cannot convert LOGICAL(4) to REAL(4) at (1)
>>
>> looks innocent to me. kpp and kselect are by default integers.
>> Maybe you can switch-off the 2018 standard somewhere, or try to enclose
>> the 2 parts of the if with further brackets like:
>>
>>    if((kpp.eq.kselect).and.(kselect.gt.0)) doit= .true.
>>
>>
>> Am 09.05.2020 um 04:50 schrieb Viswanathan Elumalai:
>>> Dear Sir/Mam
>>> Greetings
>>> I had error while compiling the wien2k 19.2 version. I could not solve
>>> it from my end. I searched in wien mail list, I did not see any report
>>> in this regards. I copied the error message here and attached the
>>> corresponding compile file.
>>>
>>> SRC_tetra/compile.msg:Error: Cannot convert LOGICAL(4) to REAL(4) at (1)
>>> SRC_tetra/compile.msg:make: *** [Makefile:108: ados.o] Error 1
>>>
>>> I am looking forward your reply.
>>> with best regards
>>>
>>> Dr. Viswanathan Elumalai,
>>> Assistant Professor in Physics
>>>
>>>
>>>
>>> _______________________________________________
>>> Wien mailing list
>>> Wien at zeus.theochem.tuwien.ac.at
>>> http://zeus.theochem.tuwien.ac.at/mailman/listinfo/wien
>>> SEARCH the MAILING-LIST at:http://www.mail-archive.com/wien@zeus.theochem.tuwien.ac.at/index.html
>>>
>> --
>> Peter Blaha
>> Inst.Materials Chemistry
>> TU Vienna
>> Getreidemarkt 9
>> A-1060 Vienna
>> Austria
>> +43-1-5880115671
> 
> _______________________________________________
> Wien mailing list
> Wien at zeus.theochem.tuwien.ac.at
> http://zeus.theochem.tuwien.ac.at/mailman/listinfo/wien
> SEARCH the MAILING-LIST at:  http://www.mail-archive.com/wien@zeus.theochem.tuwien.ac.at/index.html
> 

-- 
--------------------------------------------------------------------------
Peter BLAHA, Inst.f. Materials Chemistry, TU Vienna, A-1060 Vienna
Phone: +43-1-58801-165300             FAX: +43-1-58801-165982
Email: blaha at theochem.tuwien.ac.at    WIEN2k: http://www.wien2k.at
WWW: 
http://www.imc.tuwien.ac.at/tc_blaha-------------------------------------------------------------------------